Update firestore docs for typos #7173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dwyfrequency
requested review from
egilmorez,
markarndt,
lisajian,
prameshj,
renkelvin and
sam-gc
as code owners
markarndt
approved these changes
Mar 30, 2023
Size Report 1Affected ProductsNo changes between base commit (81cb20a) and merge commit (7d6ddab).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (81cb20a) and merge commit (7d6ddab).Test Logs |
hsubox76
requested changes
Mar 30, 2023
packages/auth/api-extractor.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "extends": "../../config/api-extractor.json", | |||
| "mainEntryPointFilePath": "<projectFolder>/dist/esm5/index.d.ts", | |||
| "mainEntryPointFilePath": "<projectFolder>/dist/esm5/index.doc.d.ts", | |||
There was a problem hiding this comment.
Revert this (the script is supposed to do it, not sure why it isn't)
hsubox76
approved these changes
Mar 30, 2023
egilmorez
approved these changes
Mar 31, 2023
sam-gc
approved these changes
Mar 31, 2023
dwyfrequency
added a commit
that referenced
this pull request
Apr 13, 2023
* Update firestore docs for typos * Revert auth change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary for internal cl/520368128 presubmit